Commit 8a430d74 authored Jan 13, 2006 by Evgeniy Committed by Linus Torvalds Jan 13, 2006

[PATCH] Fix oops in ufs_fill_super at mount time



There's a lack of parenthesis in fs/ufs/utils.h, so instead of the 512th
byte of buffer, the usb2 pointer will point to the nth structure of type
ufs_super_block_second.

This can cause a mount-time oops if you're unlucky (especially with
DEBUG_PAGEALLOC, which is how Alexey Dobriyan saw this problem)

Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
Acked-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 43ecb9a3

fs/ufs/util.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -255,8 +255,8 @@ extern void _ubh_memcpyubh_(struct ufs_sb_private_info *, struct ufs_buffer_head
		((struct ufs_super_block_first *)((ubh)->bh[0]->b_data))

		#define ubh_get_usb_second(ubh) \
		((struct ufs_super_block_second *)(ubh)-> \
		bh[UFS_SECTOR_SIZE >> uspi->s_fshift]->b_data + (UFS_SECTOR_SIZE & ~uspi->s_fmask))
		((struct ufs_super_block_second *)((ubh)->\
		bh[UFS_SECTOR_SIZE >> uspi->s_fshift]->b_data + (UFS_SECTOR_SIZE & ~uspi->s_fmask)))

		#define ubh_get_usb_third(ubh) \
		((struct ufs_super_block_third *)((ubh)-> \

Admin message