Commit 8a2fbedc authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: combine status/drop reporting 



The TX status reporting is done for both the
nl80211 report as well as the socket option.
The socket option is also reported when an
skb is dropped to guarantee that the copy in
the IDR tree is freed and status is reported
to userspace.

However, when a frame is dropped, no nl80211
status is reported. This can cause userspace
to stop making progress while waiting for a
status notification.

Combine the nl80211 and socket option status
reporting into a new function and call it in
both places -- when the status comes in from
the driver and when the skb is dropped.

While at it, also simplify the code in the
nl80211 portion a bit.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent cbc668a7

net/mac80211/status.c

+71 −74
Original line number Diff line number Diff line
@@ -325,6 +325,75 @@ static void ieee80211_add_tx_radiotap_header(struct ieee80211_supported_band 


}



static void ieee80211_report_used_skb(struct ieee80211_local *local,

				      struct sk_buff *skb, bool dropped)

{

	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);

	struct ieee80211_hdr *hdr = (void *)skb->data;

	bool acked = info->flags & IEEE80211_TX_STAT_ACK;



	if (dropped)

		acked = false;



	if (info->flags & IEEE80211_TX_INTFL_NL80211_FRAME_TX) {

		struct ieee80211_sub_if_data *sdata = NULL;

		struct ieee80211_sub_if_data *iter_sdata;

		u64 cookie = (unsigned long)skb;



		rcu_read_lock();



		if (skb->dev) {

			list_for_each_entry_rcu(iter_sdata, &local->interfaces,

						list) {

				if (!iter_sdata->dev)

					continue;



				if (skb->dev == iter_sdata->dev) {

					sdata = iter_sdata;

					break;

				}

			}

		} else {

			sdata = rcu_dereference(local->p2p_sdata);

		}



		if (!sdata)

			skb->dev = NULL;

		else if (ieee80211_is_nullfunc(hdr->frame_control) ||

			 ieee80211_is_qos_nullfunc(hdr->frame_control)) {

			cfg80211_probe_status(sdata->dev, hdr->addr1,

					      cookie, acked, GFP_ATOMIC);

		} else {

			cfg80211_mgmt_tx_status(&sdata->wdev, cookie, skb->data,

						skb->len, acked, GFP_ATOMIC);

		}



		rcu_read_unlock();

	}



	if (unlikely(info->ack_frame_id)) {

		struct sk_buff *ack_skb;

		unsigned long flags;



		spin_lock_irqsave(&local->ack_status_lock, flags);

		ack_skb = idr_find(&local->ack_status_frames,

				   info->ack_frame_id);

		if (ack_skb)

			idr_remove(&local->ack_status_frames,

				   info->ack_frame_id);

		spin_unlock_irqrestore(&local->ack_status_lock, flags);



		if (ack_skb) {

			if (!dropped) {

				/* consumes ack_skb */

				skb_complete_wifi_ack(ack_skb, acked);

			} else {

				dev_kfree_skb_any(ack_skb);

			}

		}

	}

}



/*

 * Use a static threshold for now, best value to be determined

 * by testing ...
@@ -516,62 +585,7 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb) 
					msecs_to_jiffies(10));

	}



	if (info->flags & IEEE80211_TX_INTFL_NL80211_FRAME_TX) {

		u64 cookie = (unsigned long)skb;

		bool found = false;



		acked = info->flags & IEEE80211_TX_STAT_ACK;



		rcu_read_lock();



		list_for_each_entry_rcu(sdata, &local->interfaces, list) {

			if (!sdata->dev)

				continue;



			if (skb->dev != sdata->dev)

				continue;



			found = true;

			break;

		}



		if (!skb->dev) {

			sdata = rcu_dereference(local->p2p_sdata);

			if (sdata)

				found = true;

		}



		if (!found)

			skb->dev = NULL;

		else if (ieee80211_is_nullfunc(hdr->frame_control) ||

			 ieee80211_is_qos_nullfunc(hdr->frame_control)) {

			cfg80211_probe_status(sdata->dev, hdr->addr1,

					      cookie, acked, GFP_ATOMIC);

		} else {

			cfg80211_mgmt_tx_status(&sdata->wdev, cookie, skb->data,

						skb->len, acked, GFP_ATOMIC);

		}



		rcu_read_unlock();

	}



	if (unlikely(info->ack_frame_id)) {

		struct sk_buff *ack_skb;

		unsigned long flags;



		spin_lock_irqsave(&local->ack_status_lock, flags);

		ack_skb = idr_find(&local->ack_status_frames,

				   info->ack_frame_id);

		if (ack_skb)

			idr_remove(&local->ack_status_frames,

				   info->ack_frame_id);

		spin_unlock_irqrestore(&local->ack_status_lock, flags);



		/* consumes ack_skb */

		if (ack_skb)

			skb_complete_wifi_ack(ack_skb,

				info->flags & IEEE80211_TX_STAT_ACK);

	}

	ieee80211_report_used_skb(local, skb, false);



	/* this was a transmitted frame, but now we want to reuse it */

	skb_orphan(skb);
@@ -647,25 +661,8 @@ EXPORT_SYMBOL(ieee80211_report_low_ack); 
void ieee80211_free_txskb(struct ieee80211_hw *hw, struct sk_buff *skb)

{

	struct ieee80211_local *local = hw_to_local(hw);

	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);



	if (unlikely(info->ack_frame_id)) {

		struct sk_buff *ack_skb;

		unsigned long flags;



		spin_lock_irqsave(&local->ack_status_lock, flags);

		ack_skb = idr_find(&local->ack_status_frames,

				   info->ack_frame_id);

		if (ack_skb)

			idr_remove(&local->ack_status_frames,

				   info->ack_frame_id);

		spin_unlock_irqrestore(&local->ack_status_lock, flags);



		/* consumes ack_skb */

		if (ack_skb)

			dev_kfree_skb_any(ack_skb);

	}



	ieee80211_report_used_skb(local, skb, true);

	dev_kfree_skb_any(skb);

}

EXPORT_SYMBOL(ieee80211_free_txskb);

CRA Git | Maintained and supported by SUSTech CRA and CCSE