Commit 8a1a0cd0 authored May 23, 2019 by Jason Gunthorpe

mm/hmm: Use lockdep instead of comments



So we can check locking at runtime.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Philip Yang <Philip.Yang@amd.com>

parent 47f24598

mm/hmm.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -246,11 +246,11 @@ static const struct mmu_notifier_ops hmm_mmu_notifier_ops = {
		*
		* To start mirroring a process address space, the device driver must register
		* an HMM mirror struct.
		*
		* THE mm->mmap_sem MUST BE HELD IN WRITE MODE !
		*/
		int hmm_mirror_register(struct hmm_mirror mirror, struct mm_struct mm)
		{
		lockdep_assert_held_exclusive(&mm->mmap_sem);

		/* Sanity check */
		if (!mm \|\| !mirror \|\| !mirror->ops)
		return -EINVAL;

Admin message