net: Xilinx: fix error return code (8a0a1f84) · Commits · 戴 / test

Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/ ) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by:

Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/xilinx/ll_temac_main.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1043,6 +1043,7 @@ static int temac_of_probe(struct platform_device *op)
		lp->regs = of_iomap(op->dev.of_node, 0);
		if (!lp->regs) {
		dev_err(&op->dev, "could not map temac regs.\n");
		rc = -ENOMEM;
		goto nodev;
		}

		@@ -1062,6 +1063,7 @@ static int temac_of_probe(struct platform_device *op)
		np = of_parse_phandle(op->dev.of_node, "llink-connected", 0);
		if (!np) {
		dev_err(&op->dev, "could not find DMA node\n");
		rc = -ENODEV;
		goto err_iounmap;
		}

drivers/net/ethernet/xilinx/xilinx_emaclite.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1109,6 +1109,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
		res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);
		if (!res) {
		dev_err(dev, "no IRQ found\n");
		rc = -ENXIO;
		goto error;
		}

Admin message