mfd: twl4030-irq: Check return value from twl_i2c_write() - warn() on failure (8a012ff9) · Commits · 戴 / test

In the original code a return value variable was provided, but it was never checked and the user was never informed of failure. Now it is and they are. Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/twl4030-irq.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -396,13 +396,17 @@ static int twl4030_init_sih_modules(unsigned line)
		status = twl_i2c_read(sih->module, rxbuf,
		sih->mask[line].isr_offset, sih->bytes_ixr);
		if (status < 0)
		pr_err("twl4030: err %d initializing %s %s\n",
		pr_warn("twl4030: err %d initializing %s %s\n",
		status, sih->name, "ISR");

		if (!sih->set_cor)
		if (!sih->set_cor) {
		status = twl_i2c_write(sih->module, buf,
		sih->mask[line].isr_offset,
		sih->bytes_ixr);
		if (status < 0)
		pr_warn("twl4030: write failed: %d\n",
		status);
		}
		/*
		* else COR=1 means read sufficed.
		* (for most SIH modules...)

Admin message