Commit 8a0033a9 authored Dec 15, 2014 by Timo Teräs Committed by David S. Miller Dec 15, 2014

gre: fix the inner mac header in nbma tunnel xmit path



The NBMA GRE tunnels temporarily push GRE header that contain the
per-packet NBMA destination on the skb via header ops early in xmit
path. It is the later pulled before the real GRE header is constructed.

The inner mac was thus set differently in nbma case: the GRE header
has been pushed by neighbor layer, and mac header points to beginning
of the temporary gre header (set by dev_queue_xmit).

Now that the offloads expect mac header to point to the gre payload,
fix the xmit patch to:
 - pull first the temporary gre header away
 - and reset mac header to point to gre payload

This fixes tso to work again with nbma tunnels.

Fixes: 14051f04 ("gre: Use inner mac length when computing tunnel length")
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Cc: Tom Herbert <therbert@google.com>
Cc: Alexander Duyck <alexander.h.duyck@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fd223068

net/ipv4/ip_gre.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -252,10 +252,6 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
		struct ip_tunnel *tunnel = netdev_priv(dev);
		const struct iphdr *tnl_params;

		skb = gre_handle_offloads(skb, !!(tunnel->parms.o_flags&TUNNEL_CSUM));
		if (IS_ERR(skb))
		goto out;

		if (dev->header_ops) {
		/* Need space for new headers */
		if (skb_cow_head(skb, dev->needed_headroom -
		@@ -268,6 +264,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
		* to gre header.
		*/
		skb_pull(skb, tunnel->hlen + sizeof(struct iphdr));
		skb_reset_mac_header(skb);
		} else {
		if (skb_cow_head(skb, dev->needed_headroom))
		goto free_skb;
		@@ -275,6 +272,10 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
		tnl_params = &tunnel->parms.iph;
		}

		skb = gre_handle_offloads(skb, !!(tunnel->parms.o_flags&TUNNEL_CSUM));
		if (IS_ERR(skb))
		goto out;

		__gre_xmit(skb, dev, tnl_params, skb->protocol);

		return NETDEV_TX_OK;

Admin message