Commit 89fea04c authored Jul 06, 2019 by Nishka Dasgupta Committed by Bartosz Golaszewski Jul 15, 2019

gpiolib: of: fix a memory leak in of_gpio_flags_quirks()



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a break from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.

Cc: <stable@vger.kernel.org>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
[Bartosz: tweaked the commit message]
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 541e4095

drivers/gpio/gpiolib-of.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -161,6 +161,7 @@ static void of_gpio_flags_quirks(struct device_node *np,
		of_node_full_name(child));
		*flags \|= OF_GPIO_ACTIVE_LOW;
		}
		of_node_put(child);
		break;
		}
		}

Admin message