Commit 89f33dca authored Apr 13, 2020 by Zou Wei Committed by Daniel Borkmann Apr 14, 2020

bpf: remove unneeded conversion to bool in __mark_reg_unknown



This issue was detected by using the Coccinelle software:

  kernel/bpf/verifier.c:1259:16-21: WARNING: conversion to bool not needed here

The conversion to bool is unneeded, remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Song Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/1586779076-101346-1-git-send-email-zou_wei@huawei.com

parent dfa74909

kernel/bpf/verifier.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1255,8 +1255,7 @@ static void __mark_reg_unknown(const struct bpf_verifier_env *env,
		reg->type = SCALAR_VALUE;
		reg->var_off = tnum_unknown;
		reg->frameno = 0;
		reg->precise = env->subprog_cnt > 1 \|\| !env->allow_ptr_leaks ?
		true : false;
		reg->precise = env->subprog_cnt > 1 \|\| !env->allow_ptr_leaks;
		__mark_reg_unbounded(reg);
		}

Admin message