Commit 89da3446 authored Jan 25, 2019 by Gustavo A. R. Silva Committed by Borislav Petkov Jan 26, 2019

x86/insn-eval: Mark expected switch-case fall-through



In preparation to enable -Wimplicit-fallthrough by default, mark
switch-case statements where fall-through is intentional, explicitly.

Thus fix the following warning:

  arch/x86/lib/insn-eval.c: In function ‘resolve_default_seg’:
  arch/x86/lib/insn-eval.c:179:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
     if (insn->addr_bytes == 2)
        ^
  arch/x86/lib/insn-eval.c:182:2: note: here
    case -EDOM:
    ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This is part of the ongoing efforts to enable -Wimplicit-fallthrough by
default.

 [ bp: Massage commit message. ]

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190125205520.GA9602@embeddedor

parent 2bc217c6

arch/x86/lib/insn-eval.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -179,6 +179,8 @@ static int resolve_default_seg(struct insn insn, struct pt_regs regs, int off)
		if (insn->addr_bytes == 2)
		return -EINVAL;

		/* fall through */

		case -EDOM:
		case offsetof(struct pt_regs, bx):
		case offsetof(struct pt_regs, si):

Admin message