Commit 89c7cb2c authored Jun 20, 2016 by Jiri Olsa Committed by Arnaldo Carvalho de Melo Jun 22, 2016

perf hists: Enlarge pid sort entry size



The pid sort entry currently aligns pids with 5 digits, which is not
enough for current 4 million pids limit.

This leads to unaligned ':' header-data output when we display 7 digits
pid:

  # Children      Self  Symbol                    Pid:Command
  # ........  ........  ......................  .....................
  #
       0.12%     0.12%  [.] 0x0000000000147e0f  2052894:krava
  ...

Adding 2 more digit to properly align the pid limit:

  # Children      Self  Symbol                      Pid:Command
  # ........  ........  ......................  .......................
  #
       0.12%     0.12%  [.] 0x0000000000147e0f  2052894:krava

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1466459899-1166-9-git-send-email-jolsa@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent fcd86426

tools/perf/util/hist.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -79,7 +79,7 @@ void hists__calc_col_len(struct hists hists, struct hist_entry h)

		len = thread__comm_len(h->thread);
		if (hists__new_col_len(hists, HISTC_COMM, len))
		hists__set_col_len(hists, HISTC_THREAD, len + 6);
		hists__set_col_len(hists, HISTC_THREAD, len + 8);

		if (h->ms.map) {
		len = dso__name_len(h->ms.map->dso);

tools/perf/util/sort.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -79,8 +79,8 @@ static int hist_entry__thread_snprintf(struct hist_entry he, char bf,
		{
		const char *comm = thread__comm_str(he->thread);

		width = max(7U, width) - 6;
		return repsep_snprintf(bf, size, "%5d:%-.s", he->thread->tid,
		width = max(7U, width) - 8;
		return repsep_snprintf(bf, size, "%7d:%-.s", he->thread->tid,
		width, width, comm ?: "");
		}

Admin message