kfifo: use BUG_ON (89b3ac63) · Commits · 戴 / test

Use BUG_ON(x) rather than if(x) BUG(); The semantic patch that fixes this problem is as follows: // <smpl> @@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // </smpl> Signed-off-by:

Himangi Saraogi <himangi774@gmail.com> Acked-by:

Julia Lawall <julia.lawall@lip6.fr> Cc: Stefani Seibold <stefani@seibold.net> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

lib/kfifo.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -561,8 +561,7 @@ EXPORT_SYMBOL(__kfifo_to_user_r);
		unsigned int __kfifo_dma_in_prepare_r(struct __kfifo *fifo,
		struct scatterlist *sgl, int nents, unsigned int len, size_t recsize)
		{
		if (!nents)
		BUG();
		BUG_ON(!nents);

		len = __kfifo_max_r(len, recsize);

		@@ -585,8 +584,7 @@ EXPORT_SYMBOL(__kfifo_dma_in_finish_r);
		unsigned int __kfifo_dma_out_prepare_r(struct __kfifo *fifo,
		struct scatterlist *sgl, int nents, unsigned int len, size_t recsize)
		{
		if (!nents)
		BUG();
		BUG_ON(!nents);

		len = __kfifo_max_r(len, recsize);

Admin message