Commit 89aef892 authored by David S. Miller's avatar David S. Miller
Browse files

ipv4: Delete routing cache. 



The ipv4 routing cache is non-deterministic, performance wise, and is
subject to reasonably easy to launch denial of service attacks.

The routing cache works great for well behaved traffic, and the world
was a much friendlier place when the tradeoffs that led to the routing
cache's design were considered.

What it boils down to is that the performance of the routing cache is
a product of the traffic patterns seen by a system rather than being a
product of the contents of the routing tables.  The former of which is
controllable by external entitites.

Even for "well behaved" legitimate traffic, high volume sites can see
hit rates in the routing cache of only ~%10.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fa0afcd1

include/net/route.h

+0 −1
Original line number Original line Diff line number Diff line
@@ -109,7 +109,6 @@ extern struct ip_rt_acct __percpu *ip_rt_acct; 
struct in_device;

struct in_device;

extern int		ip_rt_init(void);

extern int		ip_rt_init(void);

extern void		rt_cache_flush(struct net *net, int how);

extern void		rt_cache_flush(struct net *net, int how);

extern void		rt_cache_flush_batch(struct net *net);

extern struct rtable *__ip_route_output_key(struct net *, struct flowi4 *flp);

extern struct rtable *__ip_route_output_key(struct net *, struct flowi4 *flp);

extern struct rtable *ip_route_output_flow(struct net *, struct flowi4 *flp,

extern struct rtable *ip_route_output_flow(struct net *, struct flowi4 *flp,

					   struct sock *sk);

					   struct sock *sk);

net/ipv4/fib_frontend.c

+0 −5
Original line number Original line Diff line number Diff line
@@ -1072,11 +1072,6 @@ static int fib_netdev_event(struct notifier_block *this, unsigned long event, vo 
		rt_cache_flush(dev_net(dev), 0);

		rt_cache_flush(dev_net(dev), 0);

		break;

		break;

	case NETDEV_UNREGISTER_BATCH:

	case NETDEV_UNREGISTER_BATCH:

		/* The batch unregister is only called on the first

		 * device in the list of devices being unregistered.

		 * Therefore we should not pass dev_net(dev) in here.

		 */

		rt_cache_flush_batch(NULL);

		break;

		break;

	}

	}

	return NOTIFY_DONE;

	return NOTIFY_DONE;

net/ipv4/route.c

+13 −927

File changed.

Preview size limit exceeded, changes collapsed.

CRA Git | Maintained and supported by SUSTech CRA and CCSE