Commit 89a76171 authored by Yazen Ghannam's avatar Yazen Ghannam Committed by Borislav Petkov
Browse files

x86/MCE/AMD, EDAC/mce_amd: Add new Load Store unit McaType 



Add support for a new version of the Load Store unit bank type as
indicated by its McaType value, which will be present in future SMCA
systems.

Add the new (HWID, MCATYPE) tuple. Reuse the same name, since this is
logically the same to the user.

Also, add the new error descriptions to edac_mce_amd.

Signed-off-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200110015651.14887-2-Yazen.Ghannam@amd.com
parent 7a8bc2b0

arch/x86/include/asm/mce.h

+1 −0
Original line number Diff line number Diff line
@@ -290,6 +290,7 @@ extern void apei_mce_report_mem_error(int corrected, 
/* These may be used by multiple smca_hwid_mcatypes */

enum smca_bank_types {

	SMCA_LS = 0,	/* Load Store */

	SMCA_LS_V2,	/* Load Store */

	SMCA_IF,	/* Instruction Fetch */

	SMCA_L2_CACHE,	/* L2 Cache */

	SMCA_DE,	/* Decoder Unit */

arch/x86/kernel/cpu/mce/amd.c

+2 −0
Original line number Diff line number Diff line
@@ -78,6 +78,7 @@ struct smca_bank_name { 


static struct smca_bank_name smca_names[] = {

	[SMCA_LS]	= { "load_store",	"Load Store Unit" },

	[SMCA_LS_V2]	= { "load_store",	"Load Store Unit" },

	[SMCA_IF]	= { "insn_fetch",	"Instruction Fetch Unit" },

	[SMCA_L2_CACHE]	= { "l2_cache",		"L2 Cache" },

	[SMCA_DE]	= { "decode_unit",	"Decode Unit" },
@@ -138,6 +139,7 @@ static struct smca_hwid smca_hwid_mcatypes[] = { 


	/* ZN Core (HWID=0xB0) MCA types */

	{ SMCA_LS,	 HWID_MCATYPE(0xB0, 0x0), 0x1FFFFF },

	{ SMCA_LS_V2,	 HWID_MCATYPE(0xB0, 0x10), 0xFFFFFF },

	{ SMCA_IF,	 HWID_MCATYPE(0xB0, 0x1), 0x3FFF },

	{ SMCA_L2_CACHE, HWID_MCATYPE(0xB0, 0x2), 0xF },

	{ SMCA_DE,	 HWID_MCATYPE(0xB0, 0x3), 0x1FF },

drivers/edac/mce_amd.c

+28 −0
Original line number Diff line number Diff line
@@ -175,6 +175,33 @@ static const char * const smca_ls_mce_desc[] = { 
	"L2 Fill Data error",

};



static const char * const smca_ls2_mce_desc[] = {

	"An ECC error was detected on a data cache read by a probe or victimization",

	"An ECC error or L2 poison was detected on a data cache read by a load",

	"An ECC error was detected on a data cache read-modify-write by a store",

	"An ECC error or poison bit mismatch was detected on a tag read by a probe or victimization",

	"An ECC error or poison bit mismatch was detected on a tag read by a load",

	"An ECC error or poison bit mismatch was detected on a tag read by a store",

	"An ECC error was detected on an EMEM read by a load",

	"An ECC error was detected on an EMEM read-modify-write by a store",

	"A parity error was detected in an L1 TLB entry by any access",

	"A parity error was detected in an L2 TLB entry by any access",

	"A parity error was detected in a PWC entry by any access",

	"A parity error was detected in an STQ entry by any access",

	"A parity error was detected in an LDQ entry by any access",

	"A parity error was detected in a MAB entry by any access",

	"A parity error was detected in an SCB entry state field by any access",

	"A parity error was detected in an SCB entry address field by any access",

	"A parity error was detected in an SCB entry data field by any access",

	"A parity error was detected in a WCB entry by any access",

	"A poisoned line was detected in an SCB entry by any access",

	"A SystemReadDataError error was reported on read data returned from L2 for a load",

	"A SystemReadDataError error was reported on read data returned from L2 for an SCB store",

	"A SystemReadDataError error was reported on read data returned from L2 for a WCB store",

	"A hardware assertion error was reported",

	"A parity error was detected in an STLF, SCB EMEM entry or SRB store data by any access",

};



static const char * const smca_if_mce_desc[] = {

	"Op Cache Microtag Probe Port Parity Error",

	"IC Microtag or Full Tag Multi-hit Error",
@@ -378,6 +405,7 @@ struct smca_mce_desc { 


static struct smca_mce_desc smca_mce_descs[] = {

	[SMCA_LS]	= { smca_ls_mce_desc,	ARRAY_SIZE(smca_ls_mce_desc)	},

	[SMCA_LS_V2]	= { smca_ls2_mce_desc,	ARRAY_SIZE(smca_ls2_mce_desc)	},

	[SMCA_IF]	= { smca_if_mce_desc,	ARRAY_SIZE(smca_if_mce_desc)	},

	[SMCA_L2_CACHE]	= { smca_l2_mce_desc,	ARRAY_SIZE(smca_l2_mce_desc)	},

	[SMCA_DE]	= { smca_de_mce_desc,	ARRAY_SIZE(smca_de_mce_desc)	},

CRA Git | Maintained and supported by SUSTech CRA and CCSE