Commit 89a2a8e7 authored May 18, 2015 by Peter Oberparleiter Committed by David S. Miller May 18, 2015

s390/lcs: Fix null-pointer access in msg



An attempt to configure a CTC device as LCS results in the
following error message:

  (null): Detecting a network adapter for LCS devices failed
          with rc=-5 (0xfffffffb)

"(null)" results from access to &card->dev->dev in lcs_new_device()
which is only initialized later in the function. Fix this by using
&ccwgdev->dev instead which is initialized before lcs_new_device()
is called.

Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ffb95251

drivers/s390/net/lcs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2150,7 +2150,7 @@ lcs_new_device(struct ccwgroup_device *ccwgdev)
		rc = lcs_detect(card);
		if (rc) {
		LCS_DBF_TEXT(2, setup, "dtctfail");
		dev_err(&card->dev->dev,
		dev_err(&ccwgdev->dev,
		"Detecting a network adapter for LCS devices"
		" failed with rc=%d (0x%x)\n", rc, rc);
		lcs_stopcard(card);

Admin message