Commit 8986d37a authored Oct 30, 2014 by Ian Abbott Committed by Greg Kroah-Hartman Nov 03, 2014

staging: comedi: me4000: don't clobber command flags



The low-level Comedi drivers shouldn't change the `flags` member of
`struct comedi_cmd` as the Comedi core also uses some of those flags.
They should just ignore the flags they don't understand.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5d070cf2

drivers/staging/comedi/drivers/me4000.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -833,9 +833,6 @@ static int me4000_ai_do_cmd_test(struct comedi_device *dev,
		unsigned int scan_ticks;
		int err = 0;

		/* Only rounding flags are implemented */
		cmd->flags &= CMDF_ROUND_NEAREST \| CMDF_ROUND_UP \| CMDF_ROUND_DOWN;

		/* Round the timer arguments */
		ai_round_cmd_args(dev, s, cmd, &init_ticks, &scan_ticks, &chan_ticks);

Admin message