drm/i915: Reject undefined colorkey flags (89746e79) · Commits · 戴 / test

Check that userspace isn't passing in garbage in the colorkey ioctl flags. Signed-off-by:

drivers/gpu/drm/i915/intel_sprite.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1073,6 +1073,9 @@ int intel_sprite_set_colorkey(struct drm_device dev, void data,
		/* ignore the pointless "none" flag */
		set->flags &= ~I915_SET_COLORKEY_NONE;

		if (set->flags & ~(I915_SET_COLORKEY_DESTINATION \| I915_SET_COLORKEY_SOURCE))
		return -EINVAL;

		/* Make sure we don't try to enable both src & dest simultaneously */
		if ((set->flags & (I915_SET_COLORKEY_DESTINATION \| I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION \| I915_SET_COLORKEY_SOURCE))
		return -EINVAL;