Commit 8958fd41 authored Jun 12, 2018 by Dan Carpenter Committed by Kees Cook Jun 12, 2018

test_overflow: fix an IS_ERR() vs NULL bug



root_device_register() returns error pointers, it never returns NULL.

Fixes: ca90800a ("test_overflow: Add memory allocation overflow tests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kees Cook <keescook@chromium.org>

parent d54d35c5

lib/test_overflow.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -367,7 +367,7 @@ static int __init test_overflow_allocation(void)

		/* Create dummy device for devm_kmalloc()-family tests. */
		dev = root_device_register(device_name);
		if (!dev) {
		if (IS_ERR(dev)) {
		pr_warn("Cannot register test device\n");
		return 1;
		}

Admin message