Commit 8945a723 authored Dec 14, 2020 by Uladzislau Rezki (Sony) Committed by Linus Torvalds Dec 15, 2020

mm/vmalloc: use free_vm_area() if an allocation fails

There is a dedicated and separate function that finds and removes a
continuous kernel virtual area.  As a final step it also releases the
"area", a descriptor of corresponding vm_struct.

Use free_vmap_area() in the __vmalloc_node_range() instead of open coded
steps which are exactly the same, to perform a cleanup.

Link: https://lkml.kernel.org/r/20201116220033.1837-1-urezki@gmail.com


Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Cc: Hillf Danton <hdanton@sina.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: "Huang, Ying" <ying.huang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 34fe6537

mm/vmalloc.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2479,8 +2479,7 @@ static void __vmalloc_area_node(struct vm_struct area, gfp_t gfp_mask,
		}

		if (!pages) {
		remove_vm_area(area->addr);
		kfree(area);
		free_vm_area(area);
		return NULL;
		}

Admin message