Commit 893ded36 authored Feb 21, 2019 by Daniel Vetter Committed by Hans de Goede Mar 11, 2019

staging/vboxvideo: Another FIXME item



Found while grepping around.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190221155951.19855-1-daniel.vetter@ffwll.ch

parent a34ced45

drivers/staging/vboxvideo/vbox_irq.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox)

		validate_or_set_position_hints(vbox);
		drm_modeset_lock_all(dev);
		/*
		* FIXME: this needs to use drm_connector_list_iter and some real
		* locking for the actual data it changes, not the deprecated
		* drm_modeset_lock_all() shotgun approach.
		*/
		list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
		vbox_conn = to_vbox_connector(connector);

Admin message