Commit 8939a3af authored May 22, 2020 by Chengguang Xu Committed by Jan Kara May 22, 2020

ext2: Fix i_op setting for special inode

Let's always set special inode i_op to &ext2_special_inode_operations
regardless of CONFIG_EXT2_FS_XATTR setting. It makes sence to be able to
query extended inode flags (needing ->setattr and ->getattr callbacks)
even when CONFIG_EXT2_FS_XATTR is not set.

Link: https://lore.kernel.org/r/20200522044035.24190-1-cgxu519@mykernel.net


Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Signed-off-by: Jan Kara <jack@suse.cz>

parent 18bf3408

fs/ext2/namei.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -136,9 +136,7 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode,
		err = PTR_ERR(inode);
		if (!IS_ERR(inode)) {
		init_special_inode(inode, inode->i_mode, rdev);
		#ifdef CONFIG_EXT2_FS_XATTR
		inode->i_op = &ext2_special_inode_operations;
		#endif
		mark_inode_dirty(inode);
		err = ext2_add_nondir(dentry, inode);
		}

Admin message