arm64: psci: Avoid printing in cpu_psci_cpu_die() (891deb87) · Commits · 戴 / test

cpu_psci_cpu_die() is called in the context of the dying CPU, which will no longer be online or tracked by RCU. It is therefore not generally safe to call printk() if the PSCI "cpu off" request fails, so remove the pr_crit() invocation. Cc: Qian Cai <cai@redhat.com> Cc: "Paul E. McKenney" <paulmck@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Link: https://lore.kernel.org/r/20201106103602.9849-2-will@kernel.org Signed-off-by:

Will Deacon <will@kernel.org>

arch/arm64/kernel/psci.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -66,7 +66,6 @@ static int cpu_psci_cpu_disable(unsigned int cpu)

		static void cpu_psci_cpu_die(unsigned int cpu)
		{
		int ret;
		/*
		* There are no known implementations of PSCI actually using the
		* power state field, pass a sensible default for now.
		@@ -74,9 +73,7 @@ static void cpu_psci_cpu_die(unsigned int cpu)
		u32 state = PSCI_POWER_STATE_TYPE_POWER_DOWN <<
		PSCI_0_2_POWER_STATE_TYPE_SHIFT;

		ret = psci_ops.cpu_off(state);

		pr_crit("unable to power off CPU%u (%d)\n", cpu, ret);
		psci_ops.cpu_off(state);
		}

		static int cpu_psci_cpu_kill(unsigned int cpu)

Admin message