Commit 890766d2 authored Mar 07, 2014 by Ezequiel Garcia Committed by Dan Williams Apr 10, 2014

dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call

In mv_xor_status(), we are currently calling mv_xor_clean_completed_slots()
when the transaction is complete (the cookie status is DMA_COMPLETE).
However, a completed status means that mv_xor_slot_cleanup() was called,
which cleans the completed slots.

In other words, there's nothing to cleanup for a completed transaction in
mv_xor_status(). Remove the unneeded call to mv_xor_clean_completed_slots().

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 368da992

drivers/dma/mv_xor.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -702,10 +702,8 @@ static enum dma_status mv_xor_status(struct dma_chan *chan,
		enum dma_status ret;

		ret = dma_cookie_status(chan, cookie, txstate);
		if (ret == DMA_COMPLETE) {
		mv_xor_clean_completed_slots(mv_chan);
		if (ret == DMA_COMPLETE)
		return ret;
		}
		mv_xor_slot_cleanup(mv_chan);

		return dma_cookie_status(chan, cookie, txstate);

Admin message