Commit 89021ecc authored by Tapasweni Pathak's avatar Tapasweni Pathak Committed by Greg Kroah-Hartman
Browse files

staging: speakup: remove jiffies comparison using time_after_eq() 



This patch fixes checkpatch.pl warning in files of speakup
WARNING : Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends

Signed-off-by: default avatarTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2e94283b

drivers/staging/speakup/speakup_decext.c

+1 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ static void do_catch_up(struct spk_synth *synth) 
		else if (ch <= SPACE) {

			if (!in_escape && strchr(",.!?;:", last))

				spk_serial_out(PROCSPEECH);

			if (jiffies >= jiff_max) {

			if (time_after_eq(jiffies, jiff_max)) {

				if (!in_escape)

					spk_serial_out(PROCSPEECH);

				spin_lock_irqsave(&speakup_info.spinlock, flags);

drivers/staging/speakup/speakup_decpc.c

+1 −1
Original line number Diff line number Diff line
@@ -420,7 +420,7 @@ static void do_catch_up(struct spk_synth *synth) 
		else if (ch <= SPACE) {

			if (!in_escape && strchr(",.!?;:", last))

				dt_sendchar(PROCSPEECH);

			if (jiffies >= jiff_max) {

			if (time_after_eq(jiffies, jiff_max)) {

				if (!in_escape)

					dt_sendchar(PROCSPEECH);

				spin_lock_irqsave(&speakup_info.spinlock, flags);

drivers/staging/speakup/synth.c

+1 −1
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ void spk_do_catch_up(struct spk_synth *synth) 
			schedule_timeout(msecs_to_jiffies(full_time_val));

			continue;

		}

		if ((jiffies >= jiff_max) && (ch == SPACE)) {

		if (time_after_eq(jiffies, jiff_max) && (ch == SPACE)) {

			spin_lock_irqsave(&speakup_info.spinlock, flags);

			jiffy_delta_val = jiffy_delta->u.n.value;

			delay_time_val = delay_time->u.n.value;

CRA Git | Maintained and supported by SUSTech CRA and CCSE