Commit 88f6c779 authored Oct 26, 2020 by Zhang Qilong Committed by Greg Kroah-Hartman Nov 09, 2020

binder: change error code from postive to negative in binder_transaction



Depending on the context, the error return value
here (extra_buffers_size < added_size) should be
negative.

Acked-by: Martijn Coenen <maco@android.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201026110314.135481-1-zhangqilong3@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6c20032c

drivers/android/binder.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3103,7 +3103,7 @@ static void binder_transaction(struct binder_proc *proc,
		if (extra_buffers_size < added_size) {
		/* integer overflow of extra_buffers_size */
		return_error = BR_FAILED_REPLY;
		return_error_param = EINVAL;
		return_error_param = -EINVAL;
		return_error_line = __LINE__;
		goto err_bad_extra_size;
		}

Admin message