Commit 88edf103 authored Dec 15, 2016 by Lionel Gauthier Committed by David S. Miller Dec 17, 2016

gtp: gtp_check_src_ms_ipv4() always return success



gtp_check_src_ms_ipv4() did not find the PDP context matching with the
UE IP address because the memory location is not right, but the result
is inverted by the Boolean "not" operator.  So whatever is the PDP
context, any call to this function is successful.

Signed-off-by: Lionel Gauthier <Lionel.Gauthier@eurecom.fr>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e999cb43

drivers/net/gtp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -158,9 +158,9 @@ static bool gtp_check_src_ms_ipv4(struct sk_buff skb, struct pdp_ctx pctx,
		if (!pskb_may_pull(skb, hdrlen + sizeof(struct iphdr)))
		return false;

		iph = (struct iphdr *)(skb->data + hdrlen + sizeof(struct iphdr));
		iph = (struct iphdr *)(skb->data + hdrlen);

		return iph->saddr != pctx->ms_addr_ip4.s_addr;
		return iph->saddr == pctx->ms_addr_ip4.s_addr;
		}

		/* Check if the inner IP source address in this packet is assigned to any

Admin message