Commit 88dacbe9 authored Feb 17, 2007 by Willy Tarreau Committed by Adrian Bunk Feb 17, 2007

rio: typo in bitwise AND expression.



The line :

    hp->Mode &= !RIO_PCI_INT_ENABLE;

is obviously wrong as RIO_PCI_INT_ENABLE=0x04 and is used as a bitmask
2 lines before. Getting no IRQ would not disable RIO_PCI_INT_ENABLE
but rather RIO_PCI_BOOT_FROM_RAM which equals 0x01.

Obvious fix is to change ! for ~.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Adrian Bunk <bunk@stusta.de>

parent 8a03d9a4

drivers/char/rio/rio_linux.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1146,7 +1146,7 @@ static int __init rio_init(void)
		rio_dprintk(RIO_DEBUG_INIT, "Enabling interrupts on rio card.\n");
		hp->Mode \|= RIO_PCI_INT_ENABLE;
		} else
		hp->Mode &= !RIO_PCI_INT_ENABLE;
		hp->Mode &= ~RIO_PCI_INT_ENABLE;
		rio_dprintk(RIO_DEBUG_INIT, "New Mode: %x\n", hp->Mode);
		rio_start_card_running(hp);
		}

Admin message