Commit 88d905e2 authored by Yangtao Li's avatar Yangtao Li Committed by Herbert Xu
Browse files

crypto: cavium/nitrox - convert to DEFINE_SHOW_ATTRIBUTE



Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 8362ea16
Loading
Loading
Loading
Loading
+9 −39
Original line number Diff line number Diff line
@@ -13,18 +13,7 @@ static int firmware_show(struct seq_file *s, void *v)
	return 0;
}

static int firmware_open(struct inode *inode, struct file *file)
{
	return single_open(file, firmware_show, inode->i_private);
}

static const struct file_operations firmware_fops = {
	.owner = THIS_MODULE,
	.open = firmware_open,
	.read = seq_read,
	.llseek = seq_lseek,
	.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(firmware);

static int device_show(struct seq_file *s, void *v)
{
@@ -41,18 +30,7 @@ static int device_show(struct seq_file *s, void *v)
	return 0;
}

static int nitrox_open(struct inode *inode, struct file *file)
{
	return single_open(file, device_show, inode->i_private);
}

static const struct file_operations nitrox_fops = {
	.owner = THIS_MODULE,
	.open = nitrox_open,
	.read = seq_read,
	.llseek = seq_lseek,
	.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(device);

static int stats_show(struct seq_file *s, void *v)
{
@@ -69,18 +47,7 @@ static int stats_show(struct seq_file *s, void *v)
	return 0;
}

static int nitrox_stats_open(struct inode *inode, struct file *file)
{
	return single_open(file, stats_show, inode->i_private);
}

static const struct file_operations nitrox_stats_fops = {
	.owner = THIS_MODULE,
	.open = nitrox_stats_open,
	.read = seq_read,
	.llseek = seq_lseek,
	.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(stats);

void nitrox_debugfs_exit(struct nitrox_device *ndev)
{
@@ -97,13 +64,16 @@ int nitrox_debugfs_init(struct nitrox_device *ndev)
		return -ENOMEM;

	ndev->debugfs_dir = dir;
	f = debugfs_create_file("firmware", 0400, dir, ndev, &firmware_fops);
	f = debugfs_create_file("firmware", 0400, dir, ndev,
				&firmware_fops);
	if (!f)
		goto err;
	f = debugfs_create_file("device", 0400, dir, ndev, &nitrox_fops);
	f = debugfs_create_file("device", 0400, dir, ndev,
				&device_fops);
	if (!f)
		goto err;
	f = debugfs_create_file("stats", 0400, dir, ndev, &nitrox_stats_fops);
	f = debugfs_create_file("stats", 0400, dir, ndev,
				&stats_fops);
	if (!f)
		goto err;