Commit 88d5c343 authored by YueHaibing's avatar YueHaibing Committed by Martin K. Petersen
Browse files

scsi: megaraid_sas: Make a bunch of functions static 



Fix sparse warnings:

drivers/scsi/megaraid/megaraid_sas_fusion.c:3369:1: warning: symbol 'complete_cmd_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3535:6: warning: symbol 'megasas_sync_irqs' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3554:1: warning: symbol 'megasas_complete_cmd_dpc_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3573:13: warning: symbol 'megasas_isr_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3604:1: warning: symbol 'build_mpt_mfi_pass_thru' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3661:40: warning: symbol 'build_mpt_cmd' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3688:1: warning: symbol 'megasas_issue_dcmd_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:3881:5: warning: symbol 'megasas_wait_for_outstanding_fusion' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:4005:6: warning: symbol 'megasas_refire_mgmt_cmd' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:4525:25: warning: symbol 'megasas_get_peer_instance' was not declared. Should it be static?
drivers/scsi/megaraid/megaraid_sas_fusion.c:4825:7: warning: symbol 'megasas_fusion_crash_dump' was not declared. Should it be static?

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Acked-by: default avatarSumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4d0b32b8

drivers/scsi/megaraid/megaraid_sas_fusion.c

+14 −12
Original line number Diff line number Diff line
@@ -3510,7 +3510,7 @@ megasas_complete_r1_command(struct megasas_instance *instance, 
 * @instance:			Adapter soft state

 * Completes all commands that is in reply descriptor queue

 */

int

static int

complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex,

		    struct megasas_irq_context *irq_context)

{
@@ -3701,7 +3701,7 @@ static void megasas_enable_irq_poll(struct megasas_instance *instance) 
 * megasas_sync_irqs -	Synchronizes all IRQs owned by adapter

 * @instance:			Adapter soft state

 */

void megasas_sync_irqs(unsigned long instance_addr)

static void megasas_sync_irqs(unsigned long instance_addr)

{

	u32 count, i;

	struct megasas_instance *instance =
@@ -3759,7 +3759,7 @@ int megasas_irqpoll(struct irq_poll *irqpoll, int budget) 
 *

 * Tasklet to complete cmds

 */

void

static void

megasas_complete_cmd_dpc_fusion(unsigned long instance_addr)

{

	struct megasas_instance *instance =
@@ -3779,7 +3779,7 @@ megasas_complete_cmd_dpc_fusion(unsigned long instance_addr) 
/**

 * megasas_isr_fusion - isr entry point

 */

irqreturn_t megasas_isr_fusion(int irq, void *devp)

static irqreturn_t megasas_isr_fusion(int irq, void *devp)

{

	struct megasas_irq_context *irq_context = devp;

	struct megasas_instance *instance = irq_context->instance;
@@ -3815,7 +3815,7 @@ irqreturn_t megasas_isr_fusion(int irq, void *devp) 
 * mfi_cmd:			megasas_cmd pointer

 *

 */

void

static void

build_mpt_mfi_pass_thru(struct megasas_instance *instance,

			struct megasas_cmd *mfi_cmd)

{
@@ -3873,7 +3873,7 @@ build_mpt_mfi_pass_thru(struct megasas_instance *instance, 
 * @cmd:			mfi cmd to build

 *

 */

union MEGASAS_REQUEST_DESCRIPTOR_UNION *

static union MEGASAS_REQUEST_DESCRIPTOR_UNION *

build_mpt_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd)

{

	union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc = NULL;
@@ -3899,7 +3899,7 @@ build_mpt_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd) 
 * @cmd:			mfi cmd pointer

 *

 */

void

static void

megasas_issue_dcmd_fusion(struct megasas_instance *instance,

			  struct megasas_cmd *cmd)

{
@@ -4095,7 +4095,8 @@ static inline void megasas_trigger_snap_dump(struct megasas_instance *instance) 
}



/* This function waits for outstanding commands on fusion to complete */

int megasas_wait_for_outstanding_fusion(struct megasas_instance *instance,

static int

megasas_wait_for_outstanding_fusion(struct megasas_instance *instance,

				    int reason, int *convert)

{

	int i, outstanding, retval = 0, hb_seconds_missed = 0;
@@ -4220,7 +4221,7 @@ void megasas_reset_reply_desc(struct megasas_instance *instance) 
 * megasas_refire_mgmt_cmd :	Re-fire management commands

 * @instance:				Controller's soft instance

*/

void megasas_refire_mgmt_cmd(struct megasas_instance *instance)

static void megasas_refire_mgmt_cmd(struct megasas_instance *instance)

{

	int j;

	struct megasas_cmd_fusion *cmd_fusion;
@@ -4746,7 +4747,8 @@ out: 
}



/*SRIOV get other instance in cluster if any*/

struct megasas_instance *megasas_get_peer_instance(struct megasas_instance *instance)

static struct

megasas_instance *megasas_get_peer_instance(struct megasas_instance *instance)

{

	int i;
@@ -5052,7 +5054,7 @@ out: 
}



/* Fusion Crash dump collection */

void  megasas_fusion_crash_dump(struct megasas_instance *instance)

static void  megasas_fusion_crash_dump(struct megasas_instance *instance)

{

	u32 status_reg;

	u8 partial_copy = 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE