Commit 88ac039c authored Feb 26, 2020 by Andy Shevchenko Committed by Vinod Koul Mar 02, 2020

dmaengine: Refactor dmaengine_check_align() to be bit operations only

There is no need to have branch and temporary variable in the function.
Simple convert it to be a set of bit and arithmetic operations.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200226101842.29426-1-andriy.shevchenko@linux.intel.com

Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 9065958e

include/linux/dmaengine.h

+1 −8

Original line number	Diff line number	Diff line
		@@ -1155,14 +1155,7 @@ static inline dma_cookie_t dmaengine_submit(struct dma_async_tx_descriptor *desc
		static inline bool dmaengine_check_align(enum dmaengine_alignment align,
		size_t off1, size_t off2, size_t len)
		{
		size_t mask;

		if (!align)
		return true;
		mask = (1 << align) - 1;
		if (mask & (off1 \| off2 \| len))
		return false;
		return true;
		return !(((1 << align) - 1) & (off1 \| off2 \| len));
		}

		static inline bool is_dma_copy_aligned(struct dma_device *dev, size_t off1,