Commit 8893ab5e authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Vinod Koul
Browse files

soundwire: slave: don't init debugfs on device registration error 



The error handling flow seems incorrect, there is no reason to try and
add debugfs support if the device registration did not
succeed. Return on error.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarGuennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20200419185117.4233-2-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 01de9950

drivers/soundwire/slave.c

+2 −0
Original line number Diff line number Diff line
@@ -68,6 +68,8 @@ static int sdw_slave_add(struct sdw_bus *bus, 
		list_del(&slave->node);

		mutex_unlock(&bus->bus_lock);

		put_device(&slave->dev);



		return ret;

	}

	sdw_slave_debugfs_init(slave);

CRA Git | Maintained and supported by SUSTech CRA and CCSE