Commit 889394b1 authored Dec 08, 2008 by Felipe Balbi Committed by Greg Kroah-Hartman Jan 07, 2009

USB: gadget: don't wait for completion twice



In some obscure scenarios e.g. passing a 0-byte backing file
storage, wait_for_completion() would wait forever in fsg_cleanup().

Prevent it by completing the thread in fsg_bind() error path.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 619b572a

drivers/usb/gadget/file_storage.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -4182,6 +4182,7 @@ out:
		fsg->state = FSG_STATE_TERMINATED; // The thread is dead
		fsg_unbind(gadget);
		close_all_backing_files(fsg);
		complete(&fsg->thread_notifier);
		return rc;
		}

Admin message