Commit 88913bd8 authored Feb 21, 2018 by David Rientjes Committed by Linus Torvalds Feb 21, 2018

kernel/relay.c: limit kmalloc size to KMALLOC_MAX_SIZE

chan->n_subbufs is set by the user and relay_create_buf() does a kmalloc()
of chan->n_subbufs * sizeof(size_t *).

kmalloc_slab() will generate a warning when this fails if
chan->subbufs * sizeof(size_t *) > KMALLOC_MAX_SIZE.

Limit chan->n_subbufs to the maximum allowed kmalloc() size.

Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1802061216100.122576@chino.kir.corp.google.com


Fixes: f6302f1b ("relay: prevent integer overflow in relay_open()")
Signed-off-by: David Rientjes <rientjes@google.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9c4e6b1a

kernel/relay.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -163,7 +163,7 @@ static struct rchan_buf relay_create_buf(struct rchan chan)
		{
		struct rchan_buf *buf;

		if (chan->n_subbufs > UINT_MAX / sizeof(size_t *))
		if (chan->n_subbufs > KMALLOC_MAX_SIZE / sizeof(size_t *))
		return NULL;

		buf = kzalloc(sizeof(struct rchan_buf), GFP_KERNEL);

Admin message