Commit 887e671f authored Nov 06, 2009 by Eric Dumazet Committed by David S. Miller Nov 06, 2009

decnet: netdevice refcount leak



While working on device refcount stuff, I found a device refcount leak
through DECNET.
This nasty bug can be used to hold refcounts on any !DECNET netdevice.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f9dd09c7

net/decnet/sysctl_net_decnet.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -263,12 +263,11 @@ static int dn_def_dev_strategy(ctl_table *table,
		return -ENODEV;

		rv = -ENODEV;
		if (dev->dn_ptr != NULL) {
		if (dev->dn_ptr != NULL)
		rv = dn_dev_set_default(dev, 1);
		if (rv)
		dev_put(dev);
		}
		}

		return rv;
		}

Admin message