Commit 887dc9f2 authored Dec 15, 2015 by Eric Dumazet Committed by David S. Miller Dec 16, 2015

inet: tcp: fix inetpeer_set_addr_v4()



David Ahern added a vif field in the a4 part of inetpeer_addr struct.

This broke IPv4 TCP fast open client side and more generally tcp metrics
cache, because inetpeer_addr_cmp() is now comparing two u32 instead of
one.

inetpeer_set_addr_v4() needs to properly init vif field, otherwise
the comparison result depends on uninitialized data.

Fixes: 192132b9 ("net: Add support for VRFs to inetpeer cache")
Reported-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9b29c696

include/net/inetpeer.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -78,6 +78,7 @@ void inet_initpeers(void) __init;
		static inline void inetpeer_set_addr_v4(struct inetpeer_addr *iaddr, __be32 ip)
		{
		iaddr->a4.addr = ip;
		iaddr->a4.vif = 0;
		iaddr->family = AF_INET;
		}

Admin message