Commit 8863ada9 authored Dec 01, 2010 by Jason Wessel

kgdboc,input: Fix regression with keyboard release key and early debugging



The commit 111c1823 (kgdboc: reset
input devices (keyboards) when exiting debugger) introduced a
regression in early debugging such that you get a kernel oops on
continue (with the go command) if you boot a kernel with:

    earlyprintk=vga ekgdboc=kbd kgdbwait

The restore kgdboc_restore_input() routine schedules work for the
purpose of sending key release events for any keys that were in the
depressed state prior to entering the kernel debugger.  A simple fix
to the crash is to not invoke the schedule_work() if the kernel
system_state is anything other than SYSTEM_RUNNING.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Sergei Shtylyov <sshtylyov@mvista.com>

parent e8a7e48b

drivers/serial/kgdboc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -90,6 +90,7 @@ static DECLARE_WORK(kgdboc_restore_input_work, kgdboc_restore_input_helper);

		static void kgdboc_restore_input(void)
		{
		if (likely(system_state == SYSTEM_RUNNING))
		schedule_work(&kgdboc_restore_input_work);
		}

Admin message