Commit 885ace9e authored Jul 11, 2008 by Mike Christie Committed by James Bottomley Jul 26, 2008

[SCSI] fix shared tag map setup



Currently qla4xxx and stex pass in their can_queue values into
scsi_activate_tcq because they wanted the tag map that large.
The problem with this is that it ends up also setting the queue
depth to that large value. All we want to do this in this case
is set the device queue depth and the other device settings.
We do not need to touch the tag map sizing because the drivers
had setup that map according to their can_queue limits when the
shared map was created.

The scsi mid layer in request_fn will then handle the case where we
have more requests than available tags when it checks the host
queue ready function.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent 786231af

drivers/scsi/scsi.c

+14 −5

Original line number	Diff line number	Diff line
		@@ -902,11 +902,20 @@ void scsi_adjust_queue_depth(struct scsi_device *sdev, int tagged, int tags)

		spin_lock_irqsave(sdev->request_queue->queue_lock, flags);

		/* Check to see if the queue is managed by the block layer.
		* If it is, and we fail to adjust the depth, exit. */
		/*
		* Check to see if the queue is managed by the block layer.
		* If it is, and we fail to adjust the depth, exit.
		*
		* Do not resize the tag map if it is a host wide share bqt,
		* because the size should be the hosts's can_queue. If there
		* is more IO than the LLD's can_queue (so there are not enuogh
		* tags) request_fn's host queue ready check will handle it.
		*/
		if (!sdev->host->bqt) {
		if (blk_queue_tagged(sdev->request_queue) &&
		blk_queue_resize_tags(sdev->request_queue, tags) != 0)
		goto out;
		}

		sdev->queue_depth = tags;
		switch (tagged) {

Admin message