Commit 885a78d4 authored Oct 20, 2016 by Aaron Tomlin Committed by Jessica Yu Nov 26, 2016

module: Ensure a module's state is set accordingly during module coming cleanup code



In load_module() in the event of an error, for e.g. unknown module
parameter(s) specified we go to perform some module coming clean up
operations. At this point the module is still in a "formed" state
when it is actually going away.

This patch updates the module's state accordingly to ensure anyone on the
module_notify_list waiting for a module going away notification will be
notified accordingly.

Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Link: http://lkml.kernel.org/r/1476980293-19062-2-git-send-email-atomlin@redhat.com


Signed-off-by: Jessica Yu <jeyu@redhat.com>

parent c714965f

kernel/module.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3697,6 +3697,7 @@ static int load_module(struct load_info info, const char __user uargs,
		sysfs_cleanup:
		mod_sysfs_teardown(mod);
		coming_cleanup:
		mod->state = MODULE_STATE_GOING;
		blocking_notifier_call_chain(&module_notify_list,
		MODULE_STATE_GOING, mod);
		klp_module_going(mod);

Admin message