qede: Free netdevice only after stoping slowpath (885185df) · Commits · 戴 / test

qed needs to be informed of the removal of the qede interface prior to its actual removal, as qede has some registered callbacks that might get called async to the removal flow. Signed-off-by:

Yuval Mintz <Yuval.Mintz@cavium.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/qlogic/qede/qede_main.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -956,14 +956,20 @@ static void __qede_remove(struct pci_dev *pdev, enum qede_remove_mode mode)
		if (edev->xdp_prog)
		bpf_prog_put(edev->xdp_prog);

		free_netdev(ndev);

		/* Use global ops since we've freed edev */
		qed_ops->common->slowpath_stop(cdev);
		if (system_state == SYSTEM_POWER_OFF)
		return;
		qed_ops->common->remove(cdev);

		/* Since this can happen out-of-sync with other flows,
		* don't release the netdevice until after slowpath stop
		* has been called to guarantee various other contexts
		* [e.g., QED register callbacks] won't break anything when
		* accessing the netdevice.
		*/
		free_netdev(ndev);

		dev_info(&pdev->dev, "Ending qede_remove successfully\n");
		}

Admin message