Commit 884ed4cb authored Jun 24, 2016 by Michal Hocko Committed by Linus Torvalds Jun 24, 2016

sh: get rid of superfluous __GFP_REPEAT

__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.

PGALLOC_GFP uses __GFP_REPEAT but {pgd,pmd}_alloc allocate from
{pgd,pmd}_cache but both caches are allocating up to PAGE_SIZE objects.
This means that this flag has never been actually useful here because it
has always been used only for PAGE_ALLOC_COSTLY requests.

Link: http://lkml.kernel.org/r/1464599699-30131-15-git-send-email-mhocko@kernel.org


Signed-off-by: Michal Hocko <mhocko@suse.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 10d58bf2

arch/sh/mm/pgtable.c

+1 −1

Original line number	Diff line number	Diff line
		#include <linux/mm.h>
		#include <linux/slab.h>

		#define PGALLOC_GFP GFP_KERNEL \| __GFP_REPEAT \| __GFP_ZERO
		#define PGALLOC_GFP GFP_KERNEL \| __GFP_ZERO

		static struct kmem_cache *pgd_cachep;
		#if PAGETABLE_LEVELS > 2

Admin message