Commit 884a3b64 authored Oct 13, 2016 by Geert Uytterhoeven Committed by Richard Weinberger Oct 20, 2016

UBI: Fix crash in try_recover_peb()



    drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’:
    drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in this function

The pointer vid_hdr is indeed not initialized, leading to a crash when
it is dereferenced.

Fix this by obtaining the pointer from the VID buffer, like is done
everywhere else.

Fixes: 3291b52f ("UBI: introduce the VID buffer concept")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent a15cf34f

drivers/mtd/ubi/eba.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -741,6 +741,7 @@ static int try_recover_peb(struct ubi_volume *vol, int pnum, int lnum,
		goto out_put;
		}

		vid_hdr = ubi_get_vid_hdr(vidb);
		ubi_assert(vid_hdr->vol_type == UBI_VID_DYNAMIC);

		mutex_lock(&ubi->buf_mutex);

Admin message