net: atlantic: loopback configuration in improper place (883daa18) · Commits · 戴 / test

Initial loopback configuration should be called earlier, before starting traffic on HW blocks. Otherwise depending on race conditions it could be kept disabled. Fixes: ("net: atlantic: loopback tests via private flags") Signed-off-by:

Igor Russkikh <irusskikh@marvell.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/aquantia/atlantic/aq_nic.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -403,6 +403,8 @@ int aq_nic_start(struct aq_nic_s *self)
		if (err < 0)
		goto err_exit;

		aq_nic_set_loopback(self);

		err = self->aq_hw_ops->hw_start(self->aq_hw);
		if (err < 0)
		goto err_exit;
		@@ -413,8 +415,6 @@ int aq_nic_start(struct aq_nic_s *self)

		INIT_WORK(&self->service_task, aq_nic_service_task);

		aq_nic_set_loopback(self);

		timer_setup(&self->service_timer, aq_nic_service_timer_cb, 0);
		aq_nic_service_timer_cb(&self->service_timer);

Admin message