Commit 882dcfe5 authored Oct 10, 2019 by Karsten Graul Committed by Jakub Kicinski Oct 10, 2019

net/smc: receive returns without data



smc_cdc_rxed_any_close_or_senddone() is used as an end condition for the
receive loop. This conflicts with smc_cdc_msg_recv_action() which could
run in parallel and set the bits checked by
smc_cdc_rxed_any_close_or_senddone() before the receive is processed.
In that case we could return from receive with no data, although data is
available. The same applies to smc_rx_wait().
Fix this by checking for RCV_SHUTDOWN only, which is set in
smc_cdc_msg_recv_action() after the receive was actually processed.

Fixes: 952310cc ("smc: receive data from RMBE")
Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>

parent 29ee2701

net/smc/smc_rx.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -211,8 +211,7 @@ int smc_rx_wait(struct smc_sock smc, long timeo,
		rc = sk_wait_event(sk, timeo,
		sk->sk_err \|\|
		sk->sk_shutdown & RCV_SHUTDOWN \|\|
		fcrit(conn) \|\|
		smc_cdc_rxed_any_close_or_senddone(conn),
		fcrit(conn),
		&wait);
		remove_wait_queue(sk_sleep(sk), &wait);
		sk_clear_bit(SOCKWQ_ASYNC_WAITDATA, sk);
		@@ -310,7 +309,6 @@ int smc_rx_recvmsg(struct smc_sock smc, struct msghdr msg,
		smc_rx_update_cons(smc, 0);

		if (sk->sk_shutdown & RCV_SHUTDOWN \|\|
		smc_cdc_rxed_any_close_or_senddone(conn) \|\|
		conn->local_tx_ctrl.conn_state_flags.peer_conn_abort)
		break;

Admin message