Commit 88269b88 authored Dec 03, 2020 by Kaixu Xia Committed by Darrick J. Wong Dec 09, 2020

xfs: remove unnecessary null check in xfs_generic_create



The function posix_acl_release() test the passed-in argument and
move on only when it is non-null, so maybe the null check in
xfs_generic_create is unnecessary.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent b3b29cd1

fs/xfs/xfs_iops.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -206,9 +206,7 @@ xfs_generic_create(
		xfs_finish_inode_setup(ip);

		out_free_acl:
		if (default_acl)
		posix_acl_release(default_acl);
		if (acl)
		posix_acl_release(acl);
		return error;

Admin message