Commit 87fc0ad2 authored Oct 16, 2013 by Doug Anderson Committed by Linus Torvalds Oct 16, 2013

block/partitions/efi.c: treat size mismatch as a warning, not an error



In commit 27a7c642 ("partitions/efi: account for pmbr size in lba")
we started treating bad sizes in lba field of the partition that has the
0xEE (GPT protective) as errors.

However, we may run into these "bad sizes" in the real world if someone
uses dd to copy an image from a smaller disk to a bigger disk.  Since
this case used to work (even without using force_gpt), keep it working
and treat the size mismatch as a warning instead of an error.

Reported-by: Josh Triplett <josh@joshtriplett.org>
Reported-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Davidlohr Bueso <davidlohr@hp.com>
Tested-by: Artem Bityutskiy <dedekind1@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ef5a22be

block/partitions/efi.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -222,11 +222,16 @@ check_hybrid:
		* the disk size.
		*
		* Hybrid MBRs do not necessarily comply with this.
		*
		* Consider a bad value here to be a warning to support dd'ing
		* an image from a smaller disk to a larger disk.
		*/
		if (ret == GPT_MBR_PROTECTIVE) {
		sz = le32_to_cpu(mbr->partition_record[part].size_in_lba);
		if (sz != (uint32_t) total_sectors - 1 && sz != 0xFFFFFFFF)
		ret = 0;
		pr_debug("GPT: mbr size in lba (%u) different than whole disk (%u).\n",
		sz, min_t(uint32_t,
		total_sectors - 1, 0xFFFFFFFF));
		}
		done:
		return ret;

Admin message