Commit 87f37392 authored Jun 13, 2019 by Vlad Buslov Committed by David S. Miller Jun 14, 2019

net: sched: ingress: set 'unlocked' flag for clsact Qdisc ops

To remove rtnl lock dependency in tc filter update API when using clsact
Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in clsact Qdisc_class_ops.

Clsact Qdisc ops don't require any modifications to be used without rtnl
lock on tc filter update path. Implementation never changes its q->block
and only releases it when Qdisc is being destroyed. This means it is enough
for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to hold clsact
Qdisc reference while using it without relying on rtnl lock protection.
Unlocked Qdisc ops support is already implemented in filter update path by
unlocked cls API patch set.

Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3d797eb1

net/sched/sch_ingress.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -247,6 +247,7 @@ static void clsact_destroy(struct Qdisc *sch)
		}

		static const struct Qdisc_class_ops clsact_class_ops = {
		.flags = QDISC_CLASS_OPS_DOIT_UNLOCKED,
		.leaf = ingress_leaf,
		.find = clsact_find,
		.walk = ingress_walk,

Admin message