Commit 87ed5eb4 authored Jul 12, 2011 by Trond Myklebust

NFS: Don't use DATA_SYNC writes



If we're writing back data, and the FLUSH_STABLE flag is set, then we
always want to use NFS_FILE_SYNC, since we're always in a situation where
we're doing page reclaim, and so we want to free up the page as quickly
as possible.

If we're in the FLUSH_COND_STABLE case, then we either want to use another
unstable write (if we have to do a commit anyway) or again, we want to
use NFS_FILE_SYNC because we know that we have no more pages to write
out.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent c47abcf8

fs/nfs/write.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -872,9 +872,13 @@ static int nfs_write_rpcsetup(struct nfs_page *req,
		data->args.context = get_nfs_open_context(req->wb_context);
		data->args.lock_context = req->wb_lock_context;
		data->args.stable = NFS_UNSTABLE;
		if (how & (FLUSH_STABLE \| FLUSH_COND_STABLE)) {
		data->args.stable = NFS_DATA_SYNC;
		if (!nfs_need_commit(NFS_I(inode)))
		switch (how & (FLUSH_STABLE \| FLUSH_COND_STABLE)) {
		case 0:
		break;
		case FLUSH_COND_STABLE:
		if (nfs_need_commit(NFS_I(inode)))
		break;
		default:
		data->args.stable = NFS_FILE_SYNC;
		}

Admin message