Commit 87ddf4dc authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: cypress_m8: remove bogus disconnect test from close 



Remove disconnected test from close which did not protect any device IO
at all.

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ecb9eb80

drivers/usb/serial/cypress_m8.c

+0 −7
Original line number Diff line number Diff line
@@ -632,12 +632,6 @@ static void cypress_close(struct usb_serial_port *port) 
	struct cypress_private *priv = usb_get_serial_port_data(port);

	unsigned long flags;



	/* writing is potentially harmful, lock must be taken */

	mutex_lock(&port->serial->disc_mutex);

	if (port->serial->disconnected) {

		mutex_unlock(&port->serial->disc_mutex);

		return;

	}

	spin_lock_irqsave(&priv->lock, flags);

	kfifo_reset_out(&priv->write_fifo);

	spin_unlock_irqrestore(&priv->lock, flags);
@@ -649,7 +643,6 @@ static void cypress_close(struct usb_serial_port *port) 
	if (stats)

		dev_info(&port->dev, "Statistics: %d Bytes In | %d Bytes Out | %d Commands Issued\n",

			priv->bytes_in, priv->bytes_out, priv->cmd_count);

	mutex_unlock(&port->serial->disc_mutex);

} /* cypress_close */

CRA Git | Maintained and supported by SUSTech CRA and CCSE