Commit 87d9e568 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jason Gunthorpe
Browse files

RDMA/hns: Uninitialized variable in modify_qp_init_to_rtr() 

The "dmac" variable is used before it is initialized.

Fixes: 494c3b31 ("RDMA/hns: Refactor the QP context filling process related to WQE buffer configure")
Link: https://lore.kernel.org/r/20200529083918.GA1298465@mwanda


Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 278f74b3

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+1 −1
Original line number Diff line number Diff line
@@ -4030,6 +4030,7 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp, 
	port = (attr_mask & IB_QP_PORT) ? (attr->port_num - 1) : hr_qp->port;



	smac = (u8 *)hr_dev->dev_addr[port];

	dmac = (u8 *)attr->ah_attr.roce.dmac;

	/* when dmac equals smac or loop_idc is 1, it should loopback */

	if (ether_addr_equal_unaligned(dmac, smac) ||

	    hr_dev->loop_idc == 0x1) {
@@ -4053,7 +4054,6 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp, 
	roce_set_field(qpc_mask->byte_20_smac_sgid_idx,

		       V2_QPC_BYTE_20_SGID_IDX_M, V2_QPC_BYTE_20_SGID_IDX_S, 0);



	dmac = (u8 *)attr->ah_attr.roce.dmac;

	memcpy(&(context->dmac), dmac, sizeof(u32));

	roce_set_field(context->byte_52_udpspn_dmac, V2_QPC_BYTE_52_DMAC_M,

		       V2_QPC_BYTE_52_DMAC_S, *((u16 *)(&dmac[4])));

CRA Git | Maintained and supported by SUSTech CRA and CCSE