Commit 87ceb6a6 authored Sep 14, 2020 by Jens Axboe

io_uring: drop 'ctx' ref on task work cancelation



If task_work ends up being marked for cancelation, we go through a
cancelation helper instead of the queue path. In converting task_work to
always hold a ctx reference, this path was missed. Make sure that
io_req_task_cancel() puts the reference that is being held against the
ctx.

Fixes: 6d816e08 ("io_uring: hold 'ctx' reference around task_work queue + execute")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 202700e1

fs/io_uring.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1787,8 +1787,10 @@ static void __io_req_task_cancel(struct io_kiocb *req, int error)
		static void io_req_task_cancel(struct callback_head *cb)
		{
		struct io_kiocb *req = container_of(cb, struct io_kiocb, task_work);
		struct io_ring_ctx *ctx = req->ctx;

		__io_req_task_cancel(req, -ECANCELED);
		percpu_ref_put(&ctx->refs);
		}

		static void __io_req_task_submit(struct io_kiocb *req)

Admin message