Commit 87a53877 authored Jan 10, 2012 by Andy Whitcroft Committed by Linus Torvalds Jan 10, 2012

checkpatch: fix EXPORT_SYMBOL handling following a function



The following fragment defeats the DEVICE_ATTR style handing, check for
and ignore the close brace '}' in this context:

    int foo()
    {
    }
    DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,
                ata_scsi_lpm_show, ata_scsi_lpm_put);
    EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy);

Signed-off-by: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a1385803

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -2131,7 +2131,7 @@ sub process {
		# XXX(foo);
		# EXPORT_SYMBOL(something_foo);
		my $name = $1;
		if ($stat =~ /^.([A-Z_]+)\s\(\s($Ident)/ &&
		if ($stat =~ /^(?:.\s}\s\n)?.([A-Z_]+)\s\(\s($Ident)/ &&
		$name =~ /^${Ident}_$2/) {
		#print "FOO C name<$name>\n";
		$suppress_export{$realline_next} = 1;

Admin message